Validator can approve or deny using the queue’s robot#418
Open
iMattPro wants to merge 6 commits intophpbb:3.3.xfrom
Open
Validator can approve or deny using the queue’s robot#418iMattPro wants to merge 6 commits intophpbb:3.3.xfrom
iMattPro wants to merge 6 commits intophpbb:3.3.xfrom
Conversation
iMattPro
force-pushed
the
robot-poster
branch
from
d979b74 to
8682ef1
Compare
iMattPro
force-pushed
the
robot-poster
branch
from
b2df706 to
c51d94a
Compare
iMattPro
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the validation (approve/deny) workflow so queue actions can be posted under the queue’s configured robot account by default, with an option for validators to post as themselves.
Changes:
- Added a “post as” radio option to the approve/deny confirmation form when a robot is available.
- Introduced new language strings for “Approve as / Deny as / Yourself”.
- Extended queue posting/notification methods to support an optional poster/sender user ID (robot).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| styles/prosilver/template/manage/queue_validate.html | Adds UI controls (radio buttons) to choose whether to post as the robot or as the validator. |
| language/en/manage.php | Adds English labels for the new “post as” UI. |
| includes/objects/queue.php | Threads an optional user ID through queue replies, release-topic replies, and approve/deny PM notifications. |
| controller/manage/queue/item.php | Reads the new form field, decides whether to use the contribution type’s robot user ID, and supplies template vars for the UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue approvals and denials now post as the queue robot account by default for consistency (if the robot exists), with validators able to optionally choose to post under their own username via a radio button on the approval/denial form.